YMMV / No Smoking

• Crosses the Line Twice: This short features so many tobacco products it's downright ridiculous, especially the extended scene where Goofy tries various ways to find a cigar, cigarette, or pipe.
• Do Not Do This Cool Thing: If you believe this is an anti-smoking cartoon, there are scenes that make it come off as a Stealth Cigarette Commercial. These scenes include a 17th-century gentleman asking his squire to light his freshly-rolled cigar, a man condemned to the firing squad having his cigarette lit by said firing squad, and a skywriter telling the people below to "Smoke Lookys."
• Fair for Its Day: While the short film has a fairly enlightened message that kicking the smoking habit is significantly more difficult than it seems, and indeed it shows some of the downsides of smoking, its lack of overt discussion of the links between smoking and lung cancer probably wouldn't hold up today.
• Harsher in Hindsight: In all seriousness, a short whose premise involves Goofy trying and failing to kick his smoking habit can be a bit uncomfortable to watch with the knowledge that both his first voice actor Pinto Colvig and Walt Disney died of lung cancer as a result of their respective smoking habits.
• Overshadowed by Controversy: Much of what we know about this short is the fact that Goofy is himself depicted as a smoker.
• Squick: Some of the methods Goofy uses to grab a smoke are somewhat disgusting, such as the times when he tries to pick up a discarded cigar or cigarette from off the ground!
• Values Dissonance: Besides the numerous tobacco products, the short makes no explicit mention of the links between smoking and lung cancer, as it was made during a time before the said links became common knowledge.
• Values Resonance: That said, its message that quitting smoking is hard has aged remarkably well and still holds up today. And for those who believe this is an anti-smoking cartoon, it is a breath of fresh air from later anti-smoking PS As that come off as either preachy or nightmarish.